SSO changing display_name field

[Arametheus]

Could be a bug.

I can't figure out where in the code this is happening.

if I use SSO in the faquserdata table it changes the display_name field to be the same as the login field from faquser which of course I would like to have the users name in the display field instead.

Thanks for any help on this.

[thorsten]

Does this happen on every login? For the first login it's working as expected as we don't have the username.

[thorsten]

I think this is the issue, it re-creates a new user per login by accident:

https://github.com/thorsten/phpMyFAQ/blob/3.2/phpmyfaq/src/phpMyFAQ/Auth/AuthSso.php#L96

[Arametheus]

yes it happens everytime. if I update the field to be correct then click on my SSO link. it changes it back to the username(login field).

[thorsten]

Please try to comment out that line

[Arametheus]

yep that was the issue line. thank you.