-
Notifications
You must be signed in to change notification settings - Fork 145
Grade Icon Migration Documentation #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+14.6 KB
docs/OnTrack/UI Enhancement/Component Reviews/Resources/grade-icon-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+44.1 KB
docs/OnTrack/UI Enhancement/Component Reviews/Resources/grade-icon-usage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+14.1 KB
docs/OnTrack/UI Enhancement/Component Reviews/Resources/grade-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.1 KB
...nTrack/UI Enhancement/Component Reviews/Resources/migrated-grade-icon-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+21.4 KB
docs/OnTrack/UI Enhancement/Component Reviews/Resources/migrated-grade-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
61 changes: 61 additions & 0 deletions
61
docs/OnTrack/UI Enhancement/Component Reviews/grade-icon.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Ontrack Component review | ||
|
|
||
| ## Team Member Name | ||
| Shounak Bhalerao | S224743249 | ||
|
|
||
| ## Component Name | ||
|
|
||
| - `grade-icon.coffee` | ||
| - `grade-icon.scss` | ||
| - `grade-icon.tpl.html` | ||
|
|
||
| ## Component purpose | ||
|
|
||
| The purpose of `grade-icon` is to provide a unified simple component, for displaying the grade student is expecting. | ||
| This item, can only be seen on screens with Tutor or higher permissions. | ||
Shounaks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Component outcomes and interactions | ||
| Users can hover over this icon to get what grade student is targeting. | ||
| It's a Visual component with no interactivity or subcomponents. | ||
|
|
||
| ## Interaction with other components | ||
| ### Input | ||
| Any Component which wants to invoke this components need the following inputs | ||
| ```typescript | ||
| @Input grade: string; // project.targetGrade | ||
| ``` | ||
|
|
||
| ### Current Usages | ||
| I noticed that this component was used in `student-list` model. | ||
| In order to view this model we need to log in using the following credentials. | ||
| > username: atutor | ||
|
|
||
| > password: password | ||
|
|
||
|  | ||
|
|
||
| ## Component Migration Plan | ||
| will be following doubtfire-web's Migration Guide and refer to existing components already migrated to TypeScript to ensure my code follows the same code style & conventions. | ||
| I will be using the following as reference: [comments-modal](comments-modal.md) | ||
|
|
||
| ### Original (Image): | ||
|  | ||
|
|
||
| ### Post-Migration (Image) | ||
|  | ||
|
|
||
| ### Original (Hover) | ||
|  | ||
|
|
||
| ### Post-Migration (Hover) | ||
|  | ||
|
|
||
| > Note: | ||
| > There is a small change in the way the hover block looks | ||
| > since previously we were using Bootstrap, and now we shifted to | ||
| > Angular Material. | ||
|
|
||
| ## Referenes | ||
| - Doubtfire-web Pull Request: https://github.com/thoth-tech/doubtfire-web/pull/258 | ||
|
|
||
| ## Status of operations: PR in REVIEW | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.