-
Notifications
You must be signed in to change notification settings - Fork 145
component-review/tutorials #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aditya993388
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @returnMarcco , you have done a great job in documentating and providing a solid foundation for the tutorials component migration. You have checked all the boxes like including a screenshot but I feel that the 'Component Purpose' could be a bit more elaborated.
Here is the PR link of a documemtation that clearly describes the respective Component Purpose - #599. Please have a look at it and similarly edit your Component Purpose section.. Other than this, it's a great documentation, I could understand everything well.
Hi @aditya993388, I've elaborated on the @aNebula, could you please review this for me if necessary. Thanks for the feedback. |
aditya993388
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @returnMarcco, great work in making the changes to elaborate the Component Purpose. This section now serves it's purpose correctly. I am approving your changes!
HasinduWelarathne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @returnMarcco , great work on this “tutorials” component review! Your document captured the big picture, stepped through migration logic, and provided a sensible checklist.
Overall, the structure is clean, the checklist is comprehensive, and your style makes it easy for someone else to pick up the component and understand exactly what to test or fix. Thanks for putting in the effort,you’ve done a really solid job!
|
Thanks for the reviews everyone |
Description
Adds a component review for the
tutorialsmigration.Fixes # (issue)
Description
Adds a component review for the
unit-staff-editormigration.Fixes # (issue)
https://teams.microsoft.com/l/entity/com.microsoft.teamspace.tab.planner/tt.c_19:bd20175d09414f079490a2403f7fca74@thread.tacv2_p_njykIFLDn0iAY1at7tACfcgADgBS_h_1714385623719?tenantId=d02378ec-1688-46d5-8540-1c28b5f470f6&webUrl=https%3A%2F%2Ftasks.teams.microsoft.com%2Fteamsui%2FpersonalApp%2Falltasklists&context=%7B%22subEntityId%22%3A%22%2Fv1%2Fplan%2FnjykIFLDn0iAY1at7tACfcgADgBS%2Ftask%2FB2wpDMIWEESKpHxSv3f4iMgAM6uL%22%2C%22channelId%22%3A%2219%3Abd20175d09414f079490a2403f7fca74%40thread.tacv2%22%7D
N/A
How Has This Been Tested?
N/A
Testing Checklist:
N/A
Checklist:
N/A
How Has This Been Tested?
N/A
Testing Checklist:
N/A
Checklist: