How do we want to handle page titles? #1297
Replies: 3 comments
-
|
If Suspenders continues using the Title gem, it would be helpful for the app to add the Without the keys in Suggested addition: @stevepolitodesign Do you think a separate issue about this would be helpful, or is it better to keep it contained here for the moment until we decide whether or not to use Title? |
Beta Was this translation helpful? Give feedback.
-
|
I personally think that in the spirit of keeping Suspenders as close to Let's see what others have to say, and if we find that we want to keep our dependency with title, then we can close this issue and open a new one with your suggested improvements. |
Beta Was this translation helpful? Give feedback.
-
|
Noting that in the latest release, we removed the title gem. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
We currently rely on title to generate the
<title>. However, with the introduction of rails/rails#49702, do we still feel we need this dependency?If we want to continue using title, I think we'll need to ensure the existing regex still works.
Beta Was this translation helpful? Give feedback.
All reactions