Skip to content

Conversation

@minaslater
Copy link
Contributor

@minaslater minaslater commented Nov 12, 2025

Upgrading our internal terraform to use the latest AWS provider, so also have to update dependencies.

We have a module that uses the secrets module, so updating this first. I'd be happy to update the rest as well in a follow-up PR, if you'd like.

Copy link
Contributor

@OlamideOl1 OlamideOl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a terraform validate with this change, and this line is now deprecated from v6

region = data.aws_region.this.name

you can update it from
data.aws_region.this.name to data.aws_region.this.region

Apart from that, the change looks good.

@OlamideOl1
Copy link
Contributor

Feel free to update the rest as well if you're able to in another PR, we'll review them later too.

@minaslater
Copy link
Contributor Author

I did a terraform validate with this change, and this line is now deprecated from v6

region = data.aws_region.this.name

you can update it from data.aws_region.this.name to data.aws_region.this.region

Apart from that, the change looks good.

oh great. fixed in 8fb6c46

@OlamideOl1 OlamideOl1 merged commit 6f2ed79 into thoughtbot:main Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants