-
Notifications
You must be signed in to change notification settings - Fork 6
SCAL-277608 feat(css-variables): remove unused liveboard styling variables from documentation #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCAL-277608 feat(css-variables): remove unused liveboard styling variables from documentation #332
Conversation
…ables from documentation
Summary of ChangesHello @sanjay-satheesh-thoughtspot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a documentation cleanup by removing a set of Liveboard-specific CSS variables that are no longer actively used. The change aims to reduce clutter and ensure that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
SonarQube Quality Gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes several unused CSS variables related to liveboard styling from the CustomCssVariables interface in src/css-variables.ts. The changes are straightforward and represent a positive cleanup of the codebase, which improves maintainability by removing unused code. I have reviewed the changes and the provided code context, and I can confirm that there are no remaining usages of these variables within the given files. Therefore, the removals appear to be correct and safe. The pull request successfully achieves its goal of cleaning up unused variables.
commit: |
…ables from documentation (#332)
…ables from documentation (#332)








Ticket: https://thoughtspot.atlassian.net/browse/SCAL-277608