Skip to content

Conversation

@sanjay-satheesh-thoughtspot
Copy link
Collaborator

@gemini-code-assist
Copy link

Summary of Changes

Hello @sanjay-satheesh-thoughtspot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a documentation cleanup by removing a set of Liveboard-specific CSS variables that are no longer actively used. The change aims to reduce clutter and ensure that the CustomCssVariables interface accurately reflects the current styling capabilities, making it easier for developers to identify and utilize relevant variables.

Highlights

  • Documentation Cleanup: Several CSS variables related to Liveboard styling have been removed from the CustomCssVariables interface in src/css-variables.ts. This cleanup targets variables that are no longer in use, streamlining the available styling options and improving documentation accuracy.
  • Removed Unused Variables: Specifically, variables such as --ts-var-viz-tile-height, --ts-var-liveboard-layout-title-color, --ts-var-liveboard-header-fontsize, and various group and tile description related variables have been deprecated and removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mnk-blr
Copy link
Collaborator

mnk-blr commented Oct 16, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonar-prod-ts
Copy link

sonar-prod-ts bot commented Oct 16, 2025

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several unused CSS variables related to liveboard styling from the CustomCssVariables interface in src/css-variables.ts. The changes are straightforward and represent a positive cleanup of the codebase, which improves maintainability by removing unused code. I have reviewed the changes and the provided code context, and I can confirm that there are no remaining usages of these variables within the given files. Therefore, the removals appear to be correct and safe. The pull request successfully achieves its goal of cleaning up unused variables.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@332

commit: 3f4ee44

@sanjay-satheesh-thoughtspot sanjay-satheesh-thoughtspot merged commit fedaf34 into main Oct 17, 2025
9 checks passed
@sanjay-satheesh-thoughtspot sanjay-satheesh-thoughtspot deleted the SCAL-277608-remove-unused-variables branch October 17, 2025 01:32
ruchI9897 pushed a commit that referenced this pull request Nov 1, 2025
ruchI9897 pushed a commit that referenced this pull request Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants