Skip to content

extend env relays with zos-config #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

extend env relays with zos-config #21

merged 3 commits into from
May 5, 2025

Conversation

@Omarabdul3ziz
Copy link
Contributor

@Omarabdul3ziz Omarabdul3ziz commented Apr 16, 2025 •
edited
Loading

  • refactor network health check to require at least one instance of each service to be alive
  • fetch relays from zos-config with a fallback to environment

Omarabdul3ziz and others added 2 commits April 27, 2025 16:31
@Omarabdul3ziz
refactor network health check
00bdde3 
- require at least one instance of each service to be alive
@ashraffouda @Omarabdul3ziz
adds set relays urls from zos config
46e6df2 
Signed-off-by: Ashraf Fouda <ashraf.m.fouda@gmail.com>
@Omarabdul3ziz Omarabdul3ziz force-pushed the main_NetworkHealthCheckUpdate branch from d1eda8e to 46e6df2 Compare April 27, 2025 13:37
@Omarabdul3ziz Omarabdul3ziz changed the title refactor network health check extend env relays with zos-config Apr 27, 2025
@Omarabdul3ziz Omarabdul3ziz marked this pull request as ready for review May 1, 2025 13:23
@Omarabdul3ziz Omarabdul3ziz force-pushed the main_NetworkHealthCheckUpdate branch from e9a4166 to 67b10a2 Compare May 1, 2025 13:24
@Omarabdul3ziz Omarabdul3ziz force-pushed the main_NetworkHealthCheckUpdate branch from 67b10a2 to 865f3a9 Compare May 1, 2025 13:25
@Omarabdul3ziz Omarabdul3ziz merged commit 1d8f2ec into main May 5, 2025
@Omarabdul3ziz Omarabdul3ziz deleted the main_NetworkHealthCheckUpdate branch May 5, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashraffouda ashraffouda ashraffouda approved these changes

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

@Eslam-Nawara Eslam-Nawara Awaiting requested review from Eslam-Nawara Eslam-Nawara is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Omarabdul3ziz @ashraffouda