Fix deployment of KeepRegistryStub for external projects #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a KeepRegistry deployed contract is not found for local network we wan to deploy a stub. The script can also be used by external projects to deploy threshold network contract dependencies. When we used `keepDeployer` the external projects deployment was failing as it required the account to be defined also in the other project's hardhat configuration file. To fix that we use `deployer` named account to deploy the stub, as it will for sure be defined in other projects. To call the `approveOperatorContract` we use `keepRegistryKeeper` which is defined by default as account `0` and it matches the `deployer`.
pdyraga
approved these changes
Apr 25, 2022
| }, | ||
| keepDeployer: { | ||
| default: 0, | ||
| keepRegistryKeeper: { |
Member
There was a problem hiding this comment.
Maybe keepRegistryOwner or keepRegistryGuvnor? Keeper of keep registry sounds weird but if you don't think the alternatives are any better, I can also merge as-is.
Member
Author
There was a problem hiding this comment.
I agree it doesn't sound good, but I wanted to match the role that is defined in KeepRegistry that is named registryKeeper.
michalinacienciala
added a commit
that referenced
this pull request
Apr 25, 2022
…ve-2 Use deployer as a fallback to call approveOperatorContract For ropsten we expect that approveOperatorContract will be called by the account that is defined as keepRegistryKeeper in the hardhat config, but for hardhat local network and for usage in external project it's just fine to assume the deployer will be used as a fallback, so the external project doesn't have to define keepRegistryKeeper. This is a continuation of #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a KeepRegistry deployed contract is not found for local network we
wan to deploy a stub. The script can also be used by external projects
to deploy threshold network contract dependencies. When we used
keepDeployerthe external projects deployment was failing as itrequired the account to be defined also in the other project's hardhat
configuration file. To fix that we use
deployernamed account todeploy the stub, as it will for sure be defined in other projects.
To call the
approveOperatorContractwe usekeepRegistryKeeperwhichis defined by default as account
0and it matches thedeployer.