Qa checklist updates #57
Conversation
|
Preview uploaded to https://preview.dashboard.test.threshold.network/qa-checklist-updates/index.html. |
| fontSize="60px" | ||
| lineHeight="64px" |
There was a problem hiding this comment.
I believe we should use relative units not fixed eg. px. Eg. the screen size changes, the text still has 60px but should be smaller. So we should probably use the object syntax or the array syntax to provide responsive styles.
There was a problem hiding this comment.
I agree but we don't have designs for how each typography element should adjust at different breakpoints. I think we should ticket this out for later. We can have Liz and Sasha come up with the sizes they want and add the responsive values in a future PR. What do you think?
There was a problem hiding this comment.
started a discussion here: https://discord.com/channels/893441201628405760/935221615455789076/935221617498411079
| <Body2 paddingRight={8}>{heroText}</Body2> | ||
| <> | ||
| <Body2>{heroText1}</Body2> | ||
| <Body2>{heroText2}</Body2> | ||
| </> | ||
| ) : ( | ||
| <H4 maxW="500px">{heroText}</H4> | ||
| <Stack maxW="450px" justify="center"> | ||
| <H4>{heroText1}</H4> | ||
| <H4 noOfLines={2}>{heroText2}</H4> | ||
| </Stack> |
There was a problem hiding this comment.
I think if we set the responsive styles correctly (please see comment above) we will avoid conditional rendering for mobile.
src/components/TokenBalance.tsx
Outdated
| {isLarge ? ( | ||
| <H3 {...restProps}> | ||
| {shouldRenderTokenAmount ? _tokenAmount : "--"} | ||
| </H3> | ||
| ) : ( | ||
| <H5 {...restProps}> | ||
| {shouldRenderTokenAmount ? _tokenAmount : "--"} | ||
| </H5> | ||
| )} | ||
| {withSymbol && | ||
| tokenSymbol && | ||
| (isLarge ? ( | ||
| <Body1 alignSelf="center">{tokenSymbol}</Body1> | ||
| ) : ( | ||
| <Body3 alignSelf="center">{tokenSymbol}</Body3> | ||
| ))} |
| {/* exchange rate link */} | ||
| <HStack justify="center" mt={4}> | ||
| <ExternalLink | ||
| as="p" |
There was a problem hiding this comment.
Good point I think this is just a copy/paste issue. I've updated.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/qa-checklist-updates/index.html. |
Updates based on:
https://coda.io/d/Building-Keep_d-fmEgBNFVH/Functional-and-Visual-QA-2022-21-01_suBPC#_luA8E
https://coda.io/d/Building-Keep_d-fmEgBNFVH/T-Migration-Threshold-side_suqpx#_luWi-