Cmd line "application"#2
Conversation
this script is pretty simple right now, with not documentation. It serves my current need :)
|
Hey, thanks for the PR! I know this repo needs a lot of work, and I actually stopped using pocket for now since it can't send to my kindle easily :( Hopefully they add that back, because I like pocket better. Anyway, this stuff looks good, and I'd definitely merge something like this :) Let me know if you want me to review it the way it is, or if you do some more to it and then have me look over it later. |
|
Hey Let me add some docs then, and you can decide if that is enough for a "minimum viable product" to be merged :) Out of curiosity, what are you using instead? On Mar 26, 2013, at 2:30 PM, William Wolf notifications@github.com wrote:
|
|
Currently i'm using Readability. It has its own issues that I don't like (and doesn't support videos nicely like Pocket does), but it sends a daily digest to my kindle every day :) If Pocket makes it easy to send to kindle, I'll switch back, I like their interface + app the best. |
|
Be sure and add yourself as an author to the |
This takes the form mainly of a small blurb in the Script.pm, and hiding attributes from --help. Also satisfy some dzil warnings
This will add Contributors to all generated documentation, from git history.
|
Ok, pushed some changes. I decided to not add myself as an author, but rather add the ContributersFromGit plugin, along with a basic weaver.ini. This is in a separate commit, so can be removed if you prefer the author solution instead :) I added some command line help as well. On Mar 26, 2013, at 2:52 PM, William Wolf notifications@github.com wrote:
|
lib/WebService/Pocket/Script.pm
Outdated
There was a problem hiding this comment.
Can you make these my ( $self ) = @_; to stay consistent with the rest of the code.
|
I like it, the last thing other than my 2 comments above, is can you keep all the lines to 80 width, again just to keep consistent with the way I've done everything else. Thanks! |
|
Awesome, thanks for making those changes :) Looks good! |
|
Hmm, it seems like your |
|
Also getting errors on |
|
ohh, sorry! maybe the weaver plugin is missing? Pod::Weaver::Section::Contributors Not sure how to add those, I'll check with the #distzilla crowd On Mar 27, 2013, at 9:22 AM, William Wolf notifications@github.com wrote:
|
|
I pushed some changes that temporarily get everything working for me, I want to release this to cpan once its sorted out correctly, so maybe another PR to clean that up, and then i'll release to cpan :) |
Hey
This is by no means finished, I just figured I'd get some feedback before spending more time :) It fixes my needs for now, but wanted to know if something like this had a potential of being merged or not before spending more time