Fixes to command line application pull#3
Merged
throughnothing merged 4 commits intothroughnothing:masterfrom Mar 27, 2013
Merged
Fixes to command line application pull#3throughnothing merged 4 commits intothroughnothing:masterfrom
throughnothing merged 4 commits intothroughnothing:masterfrom
Conversation
Owner
|
Awesome, this looks good, I will test and merge it a little bit later :) Thanks again! |
Contributor
Author
|
The last one also looked good, so fingers crossed this one actually also behaves well :P On Mar 27, 2013, at 9:52 AM, William Wolf notifications@github.com wrote:
|
Owner
|
looks like this one works...I'm gonna merge and release to cpan now. |
throughnothing
added a commit
that referenced
this pull request
Mar 27, 2013
Fixes to command line application pull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I reverted your two fixes, and added new fixes:
dist.inion the missingPod::Weaver::Section::ContributorspluginMooseX::Getopt, to get the rightprint_usage_textSorry for not doing that right away, but at least I learned something new :)
if you now do something like
dzil authordeps | cpanmit should grab the missing plugin sodzil buildshould work again.I checked that the required version of
MooseX::Getoptgot into the Makefile.PL, but did not commit the Makefile.PL.dzil listdepsdoesn't show versions or out of date information, butdzil listdeps | cpanmshould install the latest of all of them I guess :)