-
Notifications
You must be signed in to change notification settings - Fork 81
Fix code in error responses #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
Contributor
|
LGTM 👍 |
Owner
Author
|
👍 |
Owner
Author
|
I will merge the changes and release the patch. Thanks folks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

It fixes #17 and closes #6.
Summary
This PR brings:
JSONAPI::Utils#jsonapi_render_errorswith the capability of rendering errors from exceptions, ActiveRecord objects and Hashes;Examples
Code:
Responses:
Endpoint:
GET http://localhost:3000/users?fields[foo]=bar&fields[foobar]=bar&include=barResponse body:
{ "errors": [ { "title": "Invalid resource", "detail": "foo is not a valid resource.", "code": "101", "status": "400" }, { "title": "Invalid resource", "detail": "foobar is not a valid resource.", "code": "101", "status": "400" }, { "title": "Invalid field", "detail": "bar is not a valid relationship of users", "code": "112", "status": "400" } ] }Endpoint:
POST http://localhost:3000/usersRequest body:
{ "data": { "type": "users", "attributes": { "first_name": "", "last_name": "" } } }Response body:
{ "errors": [ { "title": "First name can't be blank", "id": "first_name", "code": "100", "status": "422" }, { "title": "Last name can't be blank", "id": "last_name", "code": "100", "status": "422" } ] }