Improvement/record count refactoring #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78
What's this PR do?
It brings some refactoring + fixes to the record count feature.
TODOs
Background context
At Beauty Date we have a production HTTP API fully based on JSON API using
jsonapi-utilsto parse request e build responses. While optimizing an endpoint that was suffering from "N+1 queries" problem, one of our developers (@giovannibonetti) noted that when using eager load on large tables it actually ends up with an extremely low count query because of the left join associations.Manual test