High cpu usage and memory usage when access request body in middleware.

[hidakafinzelz]

Privileged issue

• I'm @tiangolo or he asked me directly to create an issue here.

Issue Content

I try the code from #1123

code

class RequestLogMiddleware(BaseHTTPMiddleware):
    def __init__(self, app: ASGIApp, dispatch: typing.Optional[DispatchFunction] = None, logger = None, white_list = []):
        self.white_list = white_list
        self.logger = logger
        self.regex_cache = dict()
        super(RequestLogMiddleware, self).__init__(app, dispatch)

    def get_trace_id(self):
        return str(uuid.uuid4())
    async def set_body(self, request: Request, body: bytes):
        async def receive() -> Message:
            return {"type": "http.request", "body": body}
        request._receive = receive

    async def get_body(self, request: Request) -> bytes:
        body = await request.body()
        await self.set_body(request, body)
        try:
            return json.load(body.decode())
        except Exception:
            return body.decode()

    def in_white_list(self, method, path):
        key = f"{method}|{path}"
        if key in self.regex_cache:
            return self.regex_cache[key]
        for method_, regex in self.white_list:
            if method == method_ and re.match(regex, path):
                if key not in self.regex_cache:
                    self.regex_cache[key] = True
                self.logger.error(f"SIZE OF CACHE: {len(self.regex_cache)}")
                return True
        if key not in self.regex_cache:
            self.regex_cache[key] = False
        self.logger.error(f"SIZE OF CACHE: {len(self.regex_cache)}")
        return False

    async def dispatch(self, request: Request, call_next: RequestResponseEndpoint) -> Response:
        await self.set_body(request, await request.body())
        req_body = await self.get_body(request)
       print(req_body)
      response = await call_next(request)
      return response

cause very high cpu mem usage,

memory usage like

each core usage is 100%

[iudeen]

Can you change your sync methods to async and check if the cpu load remains the same?

[hidakafinzelz]

Why sync methods will affect cpu load?

[RUTUPARNk]

hey, you there? have you solved this yet?