Skip to content

Conversation

@dhdld
Copy link
Contributor

@dhdld dhdld commented Oct 23, 2024

No description provided.

@github-actions github-actions bot added the lang-all Translations label Oct 23, 2024
@github-actions
Copy link
Contributor

@alejsdev alejsdev changed the title 🌐 Add Korean translation for /docs/ko/docs/fastapi-cli.md 🌐 Add Korean translation for docs/ko/docs/fastapi-cli.md Oct 23, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 23, 2024
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@BORA040126 BORA040126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi. thank Thanks for the PR.
i left comments because some sentences are unclear.
명확하지 않은 문장 위주로 제안 드렸습니다. 확인부탁드립니다!

dhdld and others added 3 commits October 24, 2024 23:41
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@dhdld
Copy link
Contributor Author

dhdld commented Oct 24, 2024

comments 확인하여 명확하지 않은 문장 수정했습니다.
Reviewed the comments and revised unclear sentences.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@sodaMelon
Copy link

sodaMelon commented Oct 27, 2024

comments 확인하여 명확하지 않은 문장 수정했습니다. Reviewed the comments and revised unclear sentences.

LGTM 💖
(수신 대기<-에 관련된 코멘트는 지웠습니다. 저도 주말동안 고민해봤는데 생각이 나질 않네요.... 수정 고생하셨습니다!)

@alejsdev alejsdev enabled auto-merge (squash) October 28, 2024 11:26
@alejsdev
Copy link
Member

Thanks for your contribution! @dhdld 🎉
And thanks for the help @sodaMelon @hard-coders 🔍

@alejsdev alejsdev merged commit 5c33269 into fastapi:master Oct 28, 2024
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants