🌐 Add Korean translation for `/docs/ko/docs/environment-variables.md` #12526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alejsdev merged 5 commits into fastapi:master from Tolerblanc:master

Nov 7, 2024

Contributor

Tolerblanc commented Oct 24, 2024

Add Korean Translation for /docs/ko/docs/environment-variables.md


          🌐 Add Korean translation for /docs/ko/docs/environment-variables.md

601d8a4

github-actions bot added the lang-all label

alejsdev added awaiting-review lang-ko labels

sodaMelon commented Oct 24, 2024 •

edited

Loading

@alejsdev hi, could you re-check with github-actions?
new page is not being created in this PR

tiangolo mentioned this pull request

⏪️ Restore previous Action outputs deployment-url and deployment-alias-url for Pages deployments cloudflare/wrangler-action#308

Closed


          Merge branch 'master' into master

b5fd7ff

Contributor

github-actions bot commented Oct 24, 2024

📝 Docs preview for commit b5fd7ff at: https://3f1da638.fastapitiangolo.pages.dev

Modified Pages

https://3f1da638.fastapitiangolo.pages.dev/ko/environment-variables/

Member

tiangolo commented Oct 24, 2024

Thanks @sodaMelon! The problem with the missing previews was handled here #12527

sodaMelon commented Oct 24, 2024

Thanks @sodaMelon! The problem with the missing previews was handled here #12527

oh hi @tiangolo, thanks!!! what a awesome speed lmao
have a nice day

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

sodaMelon reviewed

View reviewed changes

sodaMelon left a comment

hi.
To make sure your sentences read naturally and clearly, i left some suggestions.


          Apply suggestions from code review

213d5b1

- correct ambiguous expressions clearly and readably

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

Contributor Author

Tolerblanc commented Oct 26, 2024

@sodaMelon Thank you for your detailed review! I have revised everything you pointed out.

Contributor

github-actions bot commented Oct 26, 2024

📝 Docs preview for commit 213d5b1 at: https://868dd35f.fastapitiangolo.pages.dev

Modified Pages

https://868dd35f.fastapitiangolo.pages.dev/ko/environment-variables/

sodaMelon approved these changes

View reviewed changes

sodaMelon left a comment

LGTM 👍

github-actions bot added approved-1 and removed awaiting-review labels

sodaMelon commented Nov 1, 2024

hi @hard-coders @JaeHyuckSa
could you review this PR?

hard-coders reviewed

View reviewed changes

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved

Tolerblanc and others added 2 commits

November 2, 2024 14:36


          Apply suggestions from code review

5f79877

Co-authored-by: hy.lee <rurouni24@gmail.com>


          Apply suggestions from code review

bc24db7

Contributor Author

Tolerblanc commented Nov 2, 2024

@hard-coders Thank you for your review! I corrected the ambiguous parts and the parts written Python to 파이썬.

Contributor

github-actions bot commented Nov 2, 2024

📝 Docs preview for commit bc24db7 at: https://079faa4c.fastapitiangolo.pages.dev

Modified Pages

https://079faa4c.fastapitiangolo.pages.dev/ko/environment-variables/

hard-coders approved these changes

View reviewed changes

Contributor

hard-coders left a comment

LGTM 🚀

alejsdev added approved-2 and removed approved-1 labels

alejsdev enabled auto-merge (squash)

November 7, 2024 20:48

Member

alejsdev commented Nov 7, 2024

Thanks everyone for the help! @Tolerblanc @sodaMelon @hard-coders 🙌

alejsdev merged commit d28bae0 into fastapi:master

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request


          🌐 Add Korean translation for /docs/ko/docs/environment-variables.md (…

1b9b6c3

…fastapi#12526)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all lang-ko