Skip to content

🌐 Add Traditional Chinese translation for docs/zh-hant/docs/virtual-environments.md#12791

Merged
alejsdev merged 16 commits intofastapi:masterfrom
Vincy1230:dev2-hant
Dec 9, 2024
Merged

🌐 Add Traditional Chinese translation for docs/zh-hant/docs/virtual-environments.md#12791
alejsdev merged 16 commits intofastapi:masterfrom
Vincy1230:dev2-hant

Conversation

@Vincy1230
Copy link
Contributor

Add Traditional Chinese translation for virtual-environments.md
為 virtual-environments(虛擬環境)一章加入翻譯

@github-actions github-actions bot added the lang-all Translations label Nov 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

@alejsdev alejsdev changed the title 🌐 Add Traditional Chinese translation for docs/zh-hant/docs/virtual-environments.md 🌐 Add Traditional Chinese translation for docs/zh-hant/docs/virtual-environments.md Nov 7, 2024
@alejsdev alejsdev added awaiting-review lang-zh-hant Traditional Chinese translations labels Nov 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Thanks @celestywang for your suggestion in code review
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Copy link
Contributor

@KNChiu KNChiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
@Vincy1230
Copy link
Contributor Author

Vincy1230 commented Nov 27, 2024

done. @mattwang44

@github-actions github-actions bot removed the waiting label Nov 27, 2024
@github-actions
Copy link
Contributor

Copy link
Contributor

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我 review 時比較偷懶,同樣的問題只會留一次 comment,想請你再依先前的建議檢查全文是否還有同樣的問題

@github-actions
Copy link
Contributor

Copy link
Contributor

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be the last one

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
@github-actions
Copy link
Contributor

Copy link
Contributor

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@github-actions
Copy link
Contributor

@Vincy1230
Copy link
Contributor Author

Say a digression:
Why do Github Actions often get stuck on smokeshow / coverage Expected — Waiting for status to be reported when I commit pull requests for FastAPI? What's this 🤔

@github-actions github-actions bot removed the waiting label Nov 28, 2024
@Vincy1230
Copy link
Contributor Author

let me try to sync the repository again to trigger the Actions again 🤔, but why 🤔

@github-actions
Copy link
Contributor

@Vincy1230
Copy link
Contributor Author

Now it works, but... why 😭

@tiangolo
Copy link
Member

tiangolo commented Dec 9, 2024

Now it works, but... why 😭

It seems to be a hiccup on GitHub's side, related to how it stores the coverage files. It's not on your side. 😅 Don't worry about these cases. We just need to re-run the tests so that Smokeshow can collect the coverage files that were somehow lost by GitHub Actions.

@alejsdev alejsdev merged commit 671eba1 into fastapi:master Dec 9, 2024
@alejsdev
Copy link
Member

alejsdev commented Dec 9, 2024

Thanks for your help! @Vincy1230 🤓
And thanks to everyone for the reviews 🔍

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-zh-hant Traditional Chinese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants