Skip to content

Conversation

@Limsunoh
Copy link
Contributor

Add translation to docs/ko/docs/advanced/testing-dependencies.md

@github-actions github-actions bot added the lang-all Translations label Nov 26, 2024
@github-actions
Copy link
Contributor

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Nov 26, 2024

제공자는 요청당 요금을 부과할 수 있으며, 테스트를 위해 고정된 모의 사용자가 있는 경우보다 호출하는 데 시간이 더 걸릴 수 있습니다.

외부 제공자를 한 번 테스트하는 것은 필요하지만, 실행되는 모든 테스트마다 호출할 필요는 없습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, but it would be better to reveal the nuance of "want" more clearly.

Copy link
Contributor Author

@Limsunoh Limsunoh Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about rephrasing it like this?


외부 제공자를 한 번 테스트하는 것은 필요하지만, 실행되는 모든 테스트마다 호출할 필요는 없습니다.

이 경우 해당 공급자를 호출하는 종속성을 재정의하고 테스트에 대해서만 모의 사용자를 반환하는 사용자 지정 종속성을 사용할 수 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

override; "재정의"도 좋지만 계속해서 "오버라이드"를 사용하므로 여기서도 따르면 좋을거 같습니다.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Copy link
Contributor

@kwang1215 kwang1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 🔥

Copy link
Contributor

@kim-sangah kim-sangah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alejsdev alejsdev merged commit d75b81c into fastapi:master Nov 27, 2024
53 checks passed
@alejsdev
Copy link
Member

Thanks for your work! @Limsunoh 🙏
And thanks to everyone for the reviews. ✨

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants