📝 Update Request Body's tutorial002 to deal with tax=0 case#13230
Merged
tiangolo merged 3 commits intofastapi:masterfrom Jan 30, 2025
Merged
📝 Update Request Body's tutorial002 to deal with tax=0 case#13230tiangolo merged 3 commits intofastapi:masterfrom
tutorial002 to deal with tax=0 case#13230tiangolo merged 3 commits intofastapi:masterfrom
Conversation
…tax=0 Before this commit, price_with_tax was not included in the response body when tax=0, because the "if item.tax" condition gets set to false. Changing the condition to "if item.tax is not None" solves this issue
Contributor
|
📝 Docs preview for commit 4fed048 at: https://e2e4d18f.fastapitiangolo.pages.dev |
svlandeg
changed the title
tutorial002_py310.py for tax=0 situation
svlandeg
changed the title
tutorial002_py310.py for tax=0 situationtutorial002 to deal with tax=0 case
svlandeg
approved these changes
Jan 23, 2025
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks, makes sense to fine-tune this docs example to cover the case where tax is explicitely 0.0. I've gone ahead and pushed the same edit also to tutorial002.py to keep both files in sync.
Contributor
|
📝 Docs preview for commit af4029d at: https://dfabdbdc.fastapitiangolo.pages.dev |
Contributor
|
📝 Docs preview for commit d7417b9 at: https://d29af659.fastapitiangolo.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, price_with_tax was not included in the response body when tax=0, because the "if item.tax" condition gets set to false
Changing the condition to "if item.tax is not None" solves this issue