Conflict with openpyxl?

[ufoym]

Describe the bug

Importing openpyxl makes fastapi confuse types of query parameters.

To Reproduce

Here's a self-contained, minimal, reproducible, example with my use case:

import fastapi
import openpyxl   # if comment out, the result would be OK
from typing import List, Union, Optional

app = fastapi.FastAPI()

@app.get('/')
def read_items(p: Optional[Union[int, str]] = None):
    return isinstance(p, int)   # if p = 1, return false!

Description

• Open the browser and call the endpoint /.
• Input p = 1.
• It returns false.
• But I expected it to return true.
• If comment out import openpyxl, the result would be true as expected.

Environment

• OS: macOS
• FastAPI Version: 0.62.0
• Python version: 3.7.6

[falkben]

I cannot reproduce.

Tested with:

from fastapi.testclient import TestClient

client = TestClient(app)


def test_read_items():
    resp = client.get("/?p=1")
    assert resp.json() is True

[ycd]

Tested with the exact code, I wasn't able to reproduce this either.

Output

INFO:     127.0.0.1:38636 - "GET /?p=1 HTTP/1.1" 200 OK

Environment

Python 3.9.1
fastapi    0.63.0
openpyxl-3.0.5

[tiangolo]

Thanks for the help here @falkben and @ycd ! 👏 🙇

If that solves the original problem, then you can close this issue @ufoym ✔️

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

[github-actions]

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.