Skip to content

Conversation

@DeanWay
Copy link

@DeanWay DeanWay commented Sep 19, 2019

The status_code_key is set to uppercase above, leading to this check always being false.
This invalidated the expected behaviour of a specified 4xx or 4XX overriding the default 422 response

The status_code_key is set to uppercase above, leading to this check always being false.
This invalidated the expected behaviour of a specified 4xx or 4XX overriding the default 422 response
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #547 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #547   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         251    251           
  Lines        5988   5892   -96     
=====================================
- Hits         5988   5892   -96
Impacted Files Coverage Δ
fastapi/openapi/utils.py 100% <100%> (ø) ⬆️
...est_additional_responses_custom_validationerror.py 100% <0%> (ø) ⬆️
docs/src/app_testing/tutorial003.py 100% <0%> (ø) ⬆️
...t_query_params_str_validations/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_custom_swagger_ui_redirect.py 100% <0%> (ø) ⬆️
docs/src/first_steps/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_additional_responses_router.py 100% <0%> (ø) ⬆️
docs/src/application_configuration/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_duplicate_models_openapi.py 100% <0%> (ø) ⬆️
tests/test_serialize_response_dataclass.py 100% <0%> (ø) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580cf8f...2a831b1. Read the comment docs.

@DeanWay
Copy link
Author

DeanWay commented Sep 19, 2019

Just noticed #517. Either works, only difference here is moving the erroneous check away from using a string literal

@tiangolo
Copy link
Member

tiangolo commented Oct 4, 2019

Thanks @DeanWay ! I just merged #517 , so, this should be solved in the next release.

But thanks for your contribution! 🍰

@tiangolo tiangolo closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants