Add __all__ to fastapi

[hmvp]

Is your feature request related to a problem

We use mypy with the option implicit_reexport = False. This triggers on idiomatic fastapi imports because fastapi/__init__.py reexports everything without declaring any in __all__

The solution you would like

Add a __all__ for all types that should be imported from the main module.

Describe alternatives you've considered

Direct imports from the respective submodules is a workaround but all examples assume an import from the main package

Additional context

https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport

[gjedlicska]

I've created a small PR to fix this issue.

#1537

Could you test it aswell @hmvp ?

[hmvp]

#1537 fixes my issue!

[gjedlicska]

Thats good. I'm still working out some of the starlette reexports. Are you using any of the Response objects? If so, how are you importing them?
ie.:
from fastapi import Response
from fastapi.responses import JsonResponse

[hmvp]

Yeah currently we use direct imports from the place where they are defined (because mypy complains otheriwise). I don't think there is anything wrong with that, but since the docs mostly use examples that import from main, I think __all__ should match canonical usage..

[tiangolo]

Thanks for the discussion here everyone!

I added support for mypy --strict in #2547 with a lot of type annotation improvements. That should solve this use case.

It is available in FastAPI 0.63.0 🎉

[github-actions[bot]]

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.