Skip to content

fix: properly parse players with 'and' in their names #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix: properly parse players with 'and' in their names #323

merged 2 commits into from
Feb 6, 2024

Conversation

phenpessoa
Copy link
Contributor

fixes #318

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tobiasehlert tobiasehlert merged commit 9bdfb7e into tibiadata:main Feb 6, 2024
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasehlert tobiasehlert tobiasehlert approved these changes

Assignees

No one assigned

Labels

go Pull requests that update Go code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A killer having "and" in the character name who is also traded gets parsed incorrectly

2 participants

@phenpessoa @tobiasehlert