chore: refactor TibiaKillstatistics for better maintainability

[tobiasehlert]

This pull request refactors the extraction of kill statistics from HTML table rows in TibiaKillstatistics.go by introducing a helper function for improved code clarity and maintainability. It also adds comprehensive unit tests for the new helper function to ensure correct behavior and edge case handling.

Refactoring and code clarity:

• Added the extractKillStatistics helper function to encapsulate the logic for extracting and converting kill statistics from HTML nodes, replacing inline extraction logic within the main implementation. (src/TibiaKillstatistics.go, [1] [2]
• Updated the main kill statistics extraction loop to use the new helper function, simplifying the accumulation of totals and construction of Entry objects. (src/TibiaKillstatistics.go, src/TibiaKillstatistics.goL56-R67)

Testing improvements:

• Added TestExtractKillStatistics and TestExtractKillStatisticsEdgeCases unit tests to verify correct extraction from typical and edge case HTML node inputs. (src/TibiaKillstatistics_test.go, src/TibiaKillstatistics_test.goR77-R190)

Dependency updates:

• Imported the golang.org/x/net/html package in both the implementation and test files to support HTML node manipulation. (src/TibiaKillstatistics.go, [1]; src/TibiaKillstatistics_test.go, [2]

rel #453

[Copilot]

Pull Request Overview

This pull request refactors the kill statistics extraction logic in TibiaKillstatistics.go by introducing a helper function to improve code maintainability and readability. The refactoring extracts inline logic into a dedicated function and adds comprehensive unit tests.

• Extracted kill statistics parsing logic into a reusable extractKillStatistics helper function
• Simplified the main extraction loop to use the new helper function for cleaner code
• Added unit tests covering both normal cases and edge cases for the new helper function

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/TibiaKillstatistics.go	Refactored inline kill statistics extraction into a helper function and simplified main loop
src/TibiaKillstatistics_test.go	Added comprehensive unit tests for the new extractKillStatistics helper function

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud