Skip to content

Conversation

@tobiasehlert
Copy link
Member

This pull request updates how string splitting is performed in several functions by replacing usages of strings.Split with strings.SplitSeq. The change affects list parsing logic in creature loot lists, guild information, and world quest titles, likely to improve handling of input sequences or edge cases. The iteration style in the affected loops is also updated for consistency with the new splitting function.

rel #453

@tobiasehlert tobiasehlert self-assigned this Sep 23, 2025
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Sep 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes string splitting operations by replacing strings.Split with strings.SplitSeq across three files handling creature loot parsing, guild information processing, and world quest titles. The change also updates the corresponding loop iteration patterns from explicit slice iteration to range iteration over the sequence.

Key changes:

  • Replace strings.Split with strings.SplitSeq for string parsing operations
  • Update loop iteration from for _, item := range slice to for item := range sequence
  • Maintain existing filtering logic for empty strings and data processing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/TibiaWorldsWorld.go Updated world quest titles parsing to use SplitSeq
src/TibiaGuildsGuild.go Updated guild information line processing to use SplitSeq
src/TibiaCreaturesCreature.go Updated creature loot list parsing to use SplitSeq

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@tobiasehlert tobiasehlert merged commit 0483b58 into main Sep 23, 2025
5 of 6 checks passed
@tobiasehlert tobiasehlert deleted the chore-use-splitseq-instead-of-split branch September 23, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

2 participants