Skip to content

Conversation

@ChaosKid42
Copy link
Contributor

App HASS Graph:

This PR makes the App skip unknown values from HA.

I already submitted this as another PR (#2895) which was unfortunately closed.

@vincentezw : Hope you approve (again).

@tidbyt
Copy link

tidbyt bot commented Apr 13, 2025

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
🟡 Original Author The original author (vincentezw) does not match the PR author (ChaosKid42)

@ChaosKid42 ChaosKid42 force-pushed the hassgraph_fix_unknown_values branch from 0603ddd to 2b5a4d5 Compare April 13, 2025 15:58
@danielsitnik danielsitnik merged commit df44fcf into tidbyt:main Apr 16, 2025
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Apr 19, 2025
@ChaosKid42 ChaosKid42 deleted the hassgraph_fix_unknown_values branch August 24, 2025 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants