[BACK-3250] Aligns pump settings with in-range insulin data #72
+241
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves pump settings selection for date-bounded reports by aligning to the latest in-range insulin upload Ensures corresponding upload records are fetched when missing to keep device context accurate Extracts alignment logic into a testable helper and adds unit coverage for boundary cases Relates to BACK-3250
There was a problem hiding this comment.
Pull Request Overview
This PR improves pump settings selection for date-bounded reports by aligning them with the latest in-range insulin data rather than simply fetching the most recent pump settings. The refactoring extracts the alignment logic into a static, testable helper method and adds comprehensive unit tests for boundary cases.
Key changes:
- Introduces
getLatestInsulinAndPumpSettingsParamsstatic method to identify the latest in-range insulin datum (basal/bolus) and generate appropriate pump settings fetch parameters - Implements a fallback strategy: first attempts to fetch pump settings aligned with insulin data, then falls back to the latest pump settings within the date range if no aligned data exists
- Adds unit tests covering successful alignment and the null case when no in-range insulin data exists
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/report.mjs | Adds static helper method for insulin-aligned pump settings selection and refactors generate() method to use the new alignment strategy with fallback logic; includes minor style fixes (trailing comma, semicolon, import ordering) |
| test/report.test.js | Adds two test cases for the new static method covering successful pump settings param generation and null return when no in-range insulin data is found |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aligns pump settings lookup to the latest in-range pump data for continuous datasets and to upload time for non-continuous datasets to better match visualisation behavior. Passes through only supported metadata needed for downstream settings alignment and corrects a minor comment typo. Extends tests to cover new bounding rules and validate behavior across dataset types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves pump settings selection for date-bounded reports by aligning to the latest in-range insulin upload Ensures corresponding upload records are fetched when missing to keep device context accurate Extracts alignment logic into a testable helper and adds unit coverage for boundary cases
Partnered with
vizPR tidepool-org/viz#559 for WEB-3916Relates to BACK-3250