Remove bake_dependent_roles in favor of new recipes role requirements
#207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joint PR with tidymodels/recipes#1011
We've reverted the change made in hardhat 1.0.0 that implied that non-standard role columns weren't required at
forge()/bake()time. We have actually decided to take the opposite stance in recipes - i.e. we now require that all predictors and non-standard roles are present atbake()time, unless explicitly stated otherwise throughupdate_role_requirements().We now default to the following bake time role requirements, which matches the defaults of recipes:
This is essentially what pre 1.0.0 hardhat was doing (requiring all predictors, unspecified columns, and non-standard roles), with a new exception for case weights.
Additionally, we respect any changes made to these defaults through
update_role_requirements().There is full backwards compatibility with pre 1.0.0 recipes, so that hardhat can go to CRAN with these changes before recipes.