Skip to content

Remove all recipes pre-1.0.0 specific code #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Remove all recipes pre-1.0.0 specific code #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions .github/workflows/R-CMD-check-dev-recipes.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Suggests:
knitr,
Matrix,
modeldata (>= 0.0.2),
recipes (>= 0.1.8),
recipes (>= 1.0.0),
rmarkdown (>= 2.3),
roxygen2,
testthat (>= 3.0.0),
Expand Down
1 change: 0 additions & 1 deletion R/blueprint-recipe-default.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
#' processed <- mold(rec, train, blueprint = bp)
#' class(processed$predictors)
#'
#' @examplesIf utils::packageVersion("recipes") >= "0.2.0.9002"
#' # ---------------------------------------------------------------------------
#' # Non standard roles
#'
Expand Down
2 changes: 0 additions & 2 deletions man/default_recipe_blueprint.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions tests/testthat/helper-recipes.R
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions tests/testthat/test-forge-recipe.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,6 @@ test_that("non-standard roles generated in the recipe are returned by both `mold
})

test_that("`forge()` returns a slot for non standard roles that aren't required at `bake()` time", {
skip_if_no_update_role_requirements()

# This is a convention we follow to have consistency between `mold()` and `forge()`.
# Both should have the same `.$extras$roles$<name>` slot names, even if there
# wasn't any data there at `forge()` time (because it wasn't a required role).
Expand Down Expand Up @@ -567,8 +565,6 @@ test_that("`forge()` will error if required non standard roles are missing", {
})

test_that("recipes will error if the role is declared as not required, but really was", {
skip_if_no_update_role_requirements()

rec <- recipes::recipe(Species ~ ., iris)
rec <- recipes::update_role(rec, Sepal.Width, new_role = "dummy1")
rec <- recipes::update_role_requirements(rec, "dummy1", bake = FALSE)
Expand Down Expand Up @@ -605,8 +601,6 @@ test_that("`NA` roles are treated as extra roles that are required at `forge()`
})

test_that("`NA` roles can be declared as not required at `forge()` time", {
skip_if_no_update_role_requirements()

# Petal.Length, Petal.Width have `NA` roles
rec <- recipes::recipe(iris)
rec <- recipes::update_role(rec, Sepal.Length, new_role = "predictor")
Expand Down
7 changes: 0 additions & 7 deletions tests/testthat/test-mold-recipe.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ test_that("non-standard roles ptypes are stored by default", {
})

test_that("case weights is not considered a required extra role by default", {
# If we have this, we also have case weight support
skip_if_no_update_role_requirements()

iris$weight <- frequency_weights(seq_len(nrow(iris)))

rec <- recipes::recipe(Species ~ ., iris)
Expand All @@ -177,8 +174,6 @@ test_that("case weights is not considered a required extra role by default", {
})

test_that("case weights can be updated to be a required extra role", {
skip_if_no_update_role_requirements()

iris$weight <- frequency_weights(seq_len(nrow(iris)))

rec <- recipes::recipe(Species ~ ., iris)
Expand Down Expand Up @@ -368,8 +363,6 @@ test_that("`NA` roles are treated as extra roles", {
})

test_that("roles that aren't required are not retained as `extra_role_ptypes`, but are in the mold result", {
skip_if_no_update_role_requirements()

rec <- recipes::recipe(Species ~ ., iris)
rec <- recipes::update_role(rec, Sepal.Width, new_role = "dummy1")
rec <- recipes::update_role(rec, Sepal.Length, new_role = "dummy2")
Expand Down