Export recompose()
#231
Merged
Export recompose()
#231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since recipes allows for this. We don't want this in the hardhat blueprints though, as we'd prefer to nudge people towards tibbles, which hardhat tries hard to generate internally.
DavisVaughan
commented
Mar 24, 2023
| #' @description | ||
| #' `recompose()` takes a data frame and converts it into one of: | ||
| #' - A tibble | ||
| #' - A data frame |
Member
Author
There was a problem hiding this comment.
I added support for "data.frame" specifically for recipes, but hardhat won't use it
| #' The output type is determined from the `composition`. | ||
| #' | ||
| #' @export | ||
| #' @keywords internal |
Member
Author
There was a problem hiding this comment.
Internal as I don't really want people using this
EmilHvitfeldt
approved these changes
Mar 24, 2023
Member
EmilHvitfeldt
left a comment
EmilHvitfeldt
left a comment
There was a problem hiding this comment.
Checked in recipes. Looks good!
This is great, removing this duplicated logic is going to be nice
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220
It looks like
recompose()is really what we want to use in recipes