Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: hardhat
Title: Construct Modeling Packages
Version: 1.2.0.9000
Version: 1.3.0
Authors@R: c(
person("Davis", "Vaughan", , "davis@posit.co", role = c("aut", "cre")),
person("Max", "Kuhn", , "max@posit.co", role = "aut"),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# hardhat (development version)
# hardhat 1.3.0

* New family of `spruce_*_multiple()` functions to support standardizing
multi-outcome predictions (#223, with contributions from @cregouby).
Expand Down
123 changes: 1 addition & 122 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,122 +1 @@
## revdepcheck results

We checked 23 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages

## 1.2.0 Submission

This is a minor release of hardhat that rolls back some of the changes made in
hardhat 1.0.0.

## 1.1.0 Submission

This is a minor release of hardhat that follows up on the 1.0.0 release to fix
a bug that we accidentally introduced. Models fit with hardhat 0.2.0 were no
longer able to call `predict()` if hardhat 1.0.0 was installed. That was
unintentional, and has been fixed.

## 1.0.0 Submission

This is a major release of hardhat to signify that we feel that it is stable. It includes a breaking change regarding how recipe roles are handled in `forge()`. It also includes a few new functions useful for case weight handling throughout tidymodels.

## 0.2.0 Submission

This submission adds a few more `extract_*()` generics, moves `tune()` to hardhat from tune, and fixes a few bugs.

## 0.1.6 Submission

This submission adds a new family of `extract_*()` generics for usage in other tidymodels packages. It also formally removes support for logical `indicators` in `default_formula_blueprint()`, which has been soft deprecated for awhile now.

## 0.1.5 Submission

This submission adds limited support for sparse matrix output.

## 0.1.4 Submission

This submission tweaks the `indicators` argument of `default_formula_blueprint()` to allow for one hot encoding. It also fixes a small bug with character columns.

## 0.1.3 Submission

This submission keeps hardhat up to date with vctrs 0.3.0 and fixes a few bugs
regarding novel factor levels.

## 0.1.2 Submission

This submission fixes a `stringsAsFactors` note and slightly tweaks how recipes are preprocessed.

## 0.1.1 Submission

This submission fixes the test error from the new recipes 0.1.8 update.

## 0.1.0 Resubmission

### Review 3 - 2019-12-06

> You have examples for unexported functions which cannot run in this way.
Please either add hardhat::: to the function calls in the examples, omit
these examples or export these functions. e.g. scream(), shrink(), in
scream.Rd and shrink.Rd

Both `scream()` and `shrink()` are already exported, and their help files do not use any unexported functions.

> \dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user.
Does not seem necessary.
Please unwrap the examples if they are executable in < 5 sec, or replace
\dontrun{} with \donttest{}.

Removed all uses of `\dontrun{}`.

> Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation.
(See: Writing R Extensions
<https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Documenting-functions>
)
If a function does not return a value, please document that too, e.g.
\value{None}.

Added return value descriptions for all exported functions.

### Review 2 - 2019-11-28

> Please omit the redundant 'Toolkit for' from your title.

Changed the Title from "A Toolkit for the Construction of Modeling Packages" to "Construct Modeling Packages".

> The Description field is intended to be a (one paragraph) description
of what the package does and why it may be useful. Please elaborate.

Changed the Description from:

"Provides infrastructure for building new modeling packages, including functionality around preprocessing, predicting, and validating input."

to:

"Building modeling packages is hard. A large amount of effort generally goes into providing an implementation for a new method that is efficient, fast, and correct, but often less emphasis is put on the user interface. A good interface requires specialized knowledge about S3 methods and formulas, which the average package developer might not have. The goal of 'hardhat' is to reduce the burden around building new modeling packages by providing functionality for preprocessing, predicting, and validating input."

> If there are references describing (the theoretical backgrounds of) the
methods in your package, please add these in the description field of
your DESCRIPTION file in the form
authors (year) <doi:...>
authors (year) <arXiv:...>
authors (year, ISBN:...)
or if those are not available: <https:...>
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
auto-linking.

There are no references for the methods in this package.

### Review 1 - 2019-11-21

> Found the following (possibly) invalid URLs:
URL: https://github.com/tidymodels/hardhat/actions?workflow=R-CMD-check
From: README.md
Status: 404
Message: Not Found

Removed invalid URL link as requested. It is valid when signed in to GitHub,
but 404s otherwise.
There are no expected revdep failures.