make recompose() work with sparse tibbles
#259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
changed the title
recompose() work with sparse tibbles
3 tasks
hfrick
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Looks good! This is a nice breakdown of isolated tasks in #253. I'm generally very on board with PRs that do one little thing in a bigger picture. Could you, in future, link back to the bigger picture in the PR description? In this case here, I followed the breadcrumb trail of issues and PRs back to workflows where things come together and that helps me put this PR into context and review better.
sorry about that. Will do! For future readers, this PR was needed because |
hfrick
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #253