[WIP] Fixed two bugs: problems pseudo R squared and extraction of distribution info from explainer #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g: instead of R2 1-R2 was computed and used as model selection criterion. This affects all calls of explain() with n_features = 1. 2) For bin continuous = FALSE it got obvious that the extraction from explainer does not work. Note that previously an error was only thrown if: bin_continous = FALSE and use_density = TRUE. Additionally, I tried where I worked to limit the characters per row to improve readibility when debugging. Fix number one is crucial, fix number two only affects non-standard use of the package.
Closed
pkopper
changed the title
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is outlined in #156.
Initially another bug was fixed which however resulted in tests to fail.