Skip to content

fit_control() should return an S3 object #128

@DavisVaughan

Description

@DavisVaughan

I think this would be helpful because in parsnip we can just check that the input to fit(control = ) is a "parsnip_control" object, and then all the input validation can just be in fit_control().

This would also be helpful in the pipeline-ish package because when a user passes pipeline_control(parsnip_control = fit_control()) I can just check that parsnip_control is the right S3 class, and let parsnip handle the input validation. Otherwise I have to redo the input validation done by parsnip:::check_control()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions