Skip to content

fix default vaulues for mlp(engine = "brulee") #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix default vaulues for mlp(engine = "brulee") #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74ff906
fix defaults
hfrick Nov 6, 2023
8f5c9d7
update news
hfrick Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

* Improved errors in cases where the outcome column is mis-specified. (#1003)

* Documentation fixed for `mlp(engine = "brulee")`: the default values for `learn_rate` and `epochs` were swapped (#1018).

# parsnip 1.1.1

* Fixed bug where prediction on rank deficient `lm()` models produced `.pred_res` instead of `.pred`. (#985)
Expand Down
2 changes: 1 addition & 1 deletion man/rmd/mlp_brulee.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
```{r brulee-param-info, echo = FALSE}
defaults <-
tibble::tibble(parsnip = c("hidden_units", "penalty", "dropout", "epochs", "learn_rate", "activation", "mixture"),
default = c("3L", "0.0", "0.0", "0.01", "100L", "'relu'", "0.0"))
default = c("3L", "0.0", "0.0", "100L", "0.01", "'relu'", "0.0"))

param <-
mlp() %>%
Expand Down
4 changes: 2 additions & 2 deletions man/rmd/mlp_brulee.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ This model has 7 tuning parameters:

- `mixture`: Proportion of Lasso Penalty (type: double, default: 0.0)

- `epochs`: # Epochs (type: integer, default: 0.01)
- `epochs`: # Epochs (type: integer, default: 100L)

- `dropout`: Dropout Rate (type: double, default: 0.0)

- `learn_rate`: Learning Rate (type: double, default: 100L)
- `learn_rate`: Learning Rate (type: double, default: 0.01)

- `activation`: Activation Function (type: character, default: 'relu')

Expand Down