Check valid spec mode #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_spec objects of parsnip. Includes at least one expect_error per model_spec.
Contributor
Author
|
I will make these changes and redo the PR 👍 |
juliasilge
approved these changes
May 3, 2021
Member
juliasilge
left a comment
juliasilge
left a comment
There was a problem hiding this comment.
Thank you so much @jtlandis! 🙌
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is to fix the small bug found in #467 . This pull request will prevent users from adding an incompatible
modeto amodel_specobject viaset_mode.The implementation was simple:
new_model_specthat checks class and mode compatibility into a separate functioncheck_spec_mode_valnew_model_specwith new functionset_modeI also added about 47 additional tests in the file
tests/testthat/test_spec_and_modes.R. Some of these may be redundant as they simply check that compatiblemodes can be added to a givenmodel_spec. The novel part of the test that script includesexpect_errorfor when adding an impropermodetype.