make lightgbm's num_leaves engine arg tunable
#838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
reviewed
Nov 2, 2022
Contributor
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
This looks great!
Having the news bullet here instead of bonsai feels a little off but I guess it's the best place?
I will be making some related changes in bonsai anyway and can send a release out with NEWS there. I'd say we're fine to include the NEWS entry here as well!
Just "Comment"ing rather than approving merge since we'll discuss release timeline for parsnip in the group meeting tomorrow. If we plan on parsnip going out in coming days, consider this an "Approve" once that release is out. :)
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of tidymodels/dials#256 to make the
num_leavesengine arg of lightgbm tunable.Having the news bullet here instead of bonsai feels a little off but I guess it's the best place?