Skip to content

use vec_detect_missing instead of vc_equal_na #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hfrick merged 1 commit into from
Oct 27, 2022
Merged

use vec_detect_missing instead of vc_equal_na #368

hfrick merged 1 commit into from
Oct 27, 2022

Conversation

@EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented Oct 24, 2022

vec_equal_na() has been renamed to vec_detect_missing() to align better with vctrs naming conventions. vec_equal_na() will stick around for a few minor versions, but has been formally soft-deprecated (#1672).

@EmilHvitfeldt EmilHvitfeldt requested a review from hfrick October 25, 2022 21:05
hfrick
hfrick approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hfrick hfrick merged commit 7033c98 into main Oct 27, 2022
@hfrick hfrick deleted the vctrs-0.5.0-deprecation branch October 27, 2022 14:45
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hfrick hfrick hfrick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmilHvitfeldt @hfrick