remove support for foreach #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
reviewed
Apr 28, 2025
Addresses:
```
❯ checking dependencies in R code ... WARNING
'::' or ':::' import not declared from: ‘foreach’
Namespace in Imports field not imported from: ‘doFuture’
All declared Imports should be used.
❯ checking R code for possible problems ... NOTE
multi_net_helper : <anonymous>: no visible binding for global variable
‘.sum’
(/home/runner/work/stacks/stacks/check/stacks.Rcheck/00_pkg_src/stacks/R/expressions.R:175-184)
Undefined global functions or variables:
.sum
```
Considering inlining `foreach::getDoParWorkers()` but will just remove that dependency when the warning is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234.
Looks like we first introduced support for future in this package a little over a year ago. Opted not to raise a warning with only a foreach backend registered, as CRAN tune does, as it would be redundant with that warning.