Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit_best() #586

Merged
merged 16 commits into from
Jan 10, 2023
Merged

fit_best() #586

merged 16 commits into from
Jan 10, 2023

Conversation

topepo
Copy link
Member

@topepo topepo commented Dec 5, 2022

PR for generating a model fit from tuning results using the numerically best tuning parameter configurations.

My use of cli for the messaging could be better, so please suggest improvements.

@topepo topepo marked this pull request as ready for review December 5, 2022 19:08
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of notes on my first read-through

R/fit_best.R Outdated Show resolved Hide resolved
R/fit_best.R Outdated Show resolved Hide resolved
R/fit_best.R Show resolved Hide resolved
R/fit_best.R Outdated Show resolved Hide resolved
R/fit_best.R Outdated Show resolved Hide resolved
R/fit_best.R Outdated Show resolved Hide resolved
@simonpcouch
Copy link
Contributor

Heads up: will go ahead and pull + make edits to resolve Emil's review comments and workshop cli calls!

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handing off! Really excited about this addition.

R/fit_best.R Outdated Show resolved Hide resolved
@topepo topepo merged commit fcd4476 into main Jan 10, 2023
@topepo topepo deleted the fit-best branch January 10, 2023 21:36
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants