Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storms data to 2020 #6000

Merged
merged 5 commits into from
Sep 17, 2021
Merged

Update storms data to 2020 #6000

merged 5 commits into from
Sep 17, 2021

Conversation

steveharoz
Copy link
Contributor

@steveharoz steveharoz commented Sep 5, 2021 •
edited
Loading

  • The storms data only went up to 2015, so I updated the data through 2020.

  • More easy to update in the future: The code for generating the storms dataset depended on a file that was not available and used deprecated functions. These issues have been fixed. As long as the data source URL is updated, it should be simple to rerun and update this dataset annually.

  • I added some example code for the storms man page (see graph below)

  • Clarified the units and meaning of the diameter columns

  • Possible breaking change: I changed ts_diameter and hu_diameter to tropicalstorm_force_diameter and hurricane_force_diameter. They weren't used in any examples, and barely used in other github repositories, so impact should be very minimal.

  • Fixes issue Number of storms in storms #5899 and @romainfrancois's comment.

image

@romainfrancois romainfrancois merged commit 06e2fdd into tidyverse:master Sep 17, 2021
@erikmeesters
Copy link

Hi guys, I'm a coral reef ecologist working in an EU project on Caribbean coral reefs and very interested in these scripts and figures, however, I'm not very familiar with github. I can code R, but I'm not an expert like you guys (more old school I fear). Can I use your code and examples? I've downloaded the latest hurdat text file and used your script to make it into a normal data frame. Seems to work all fine. It's a great help. Thanks for this. Erik

@steveharoz
Copy link
Contributor Author

Hi @erikmeesters. Of course! All the code here is freely available via the MIT license.

For future reference, go to the root of the repository (https://github.com/tidyverse/dplyr/), and open the LICENSE.md file.

@erikmeesters
Copy link

erikmeesters commented Dec 9, 2021 via email

@tomalrussell tomalrussell mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainfrancois romainfrancois romainfrancois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveharoz @erikmeesters @romainfrancois