Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup_params method to Geom #3509

merged 2 commits into from Aug 29, 2019


Copy link

For unknown reasons Geom and subclasses doesn't have a setup_params() method. It may have not been needed before, but for consistency this PR add's it and calls it right before setup_data()

This will make certain parts of #3506 look better/more consistent

hadley approved these changes Aug 29, 2019
@thomasp85 thomasp85 merged commit 15263f7 into tidyverse:master Aug 29, 2019
Copy link

lock bot commented Feb 28, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue.

@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants