Fix error message in check_names_df.logical() #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error message for logical index vector of wrong length
|
Thanks! |
|
If you want to update a pull request, you can just push to the same branch. I fixed the tests myself (101e35a). |
krlmlr
added a commit
that referenced
this pull request
Jan 20, 2018
- `enframe(NULL)` now returns the same as `enframe(logical())` (#352). - `tbl[1, , drop = TRUE]` now behaves identically to data frames (#367). - The `tibble.width` option is honored again (#369). - Faster printing of very wide tibbles (#360). - Update vignette to match changes in 1.4.1 (#368, @bgreenwell). - Don't rely on `ncol()` for `glimpse()`, only query `nrow()` and `head()`. - Return input for zero-column data frames. - Add test for `glimpse()` with unknown rows (#366, @kevinykuo). - Faster construction and subsetting for tibbles (#353). - `tribble()` now ignores trailing commas (#342, @LaDilettante). - Fix error message when accessing columns using a logical index vector (#337, @mundl).
krlmlr
added a commit
that referenced
this pull request
Jan 23, 2018
Bug fixes --------- - Fix OS X builds. - The `tibble.width` option is honored again (#369). - `tbl[1, , drop = TRUE]` now behaves identically to data frames (#367). - Fix error message when accessing columns using a logical index vector (#337, @mundl). - `glimpse()` returns its input for zero-column data frames. Features -------- - `enframe(NULL)` now returns the same as `enframe(logical())` (#352). - `tribble()` now ignores trailing commas (#342, @LaDilettante). - Updated vignettes and website documentation. Performance ----------- - Faster printing of very wide tibbles (#360). - Faster construction and subsetting for tibbles (#353). - Only call `nrow()` and `head()` in `glimpse()`, not `ncol()`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error message for logical index vector of wrong length