[Enhancement] Support debug print for unsigned char datatype #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update debug_print_buffer_value template specialization for unsigned char - Modify test_tilelang_debug_print.py to include additional dtype tests - Add test case for uint8 dtype in debug print buffer function
- Improve code formatting for debug_print_buffer_value template specialization - Adjust line breaks and indentation for better readability - Maintain consistent code style with other template specializations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the debugging functionality and enhance the flexibility of the
debug_print_bufferfunction. The most important changes include modifying the specialization for theunsigned chartype in thedebug_print_buffer_valuefunction and updating thedebug_print_bufferfunction to accept adtypeparameter.Enhancements to debugging functionality:
src/tl_templates/cuda/debug.h: Modified thedebug_print_buffer_valuefunction to specialize forunsigned charinstead ofchar.Flexibility improvements:
testing/python/debug/test_tilelang_debug_print.py: Updated thedebug_print_bufferfunction to accept adtypeparameter, allowing different data types to be specified.testing/python/debug/test_tilelang_debug_print.py: Added multiple calls todebug_print_bufferwith differentdtypevalues in thetest_debug_print_bufferfunction to test the new functionality.Fix for issue #142