Skip to content

Conversation

@acidicMercury8
Copy link
Contributor

I noticed the russian translation here and as a native speaker I decided to improve it. The markup problems and markdownlint warnings were fixed along the way

Copy link
Owner

@tilkinsc tilkinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your translation efforts! I like the changes to the text, but there are a few loose ends which you were not aware of. Please review the changes and I'll happily accept this PR!

If you want, more needs translated to russian!
https://github.com/tilkinsc/LuaConsole/blob/master/root/lang/russian.txt

However, LuaConsole doesn't yet fully support multi-language in that it may be broken in some way. I have been busy with life and will get to it eventually!

@acidicMercury8
Copy link
Contributor Author

acidicMercury8 commented Apr 27, 2021

I was going to fix russian localization file in a next pull request. Also I can suggest using the GNU way (throw using .mo/.po files) as a cross-platform one-stop solution for localization/internationalization

@tilkinsc
Copy link
Owner

tilkinsc commented Apr 27, 2021

This repo has been designed around not having external dependencies. It's not supposed to have flashy OS-dependent features, nor creative libraries which extend functionality at the cost of them being external. Especially not under a GPL license.

Please note that CI is currently failing due to the Lua team uploading a fake .tar.gz (its just a .tar)

@acidicMercury8
Copy link
Contributor Author

I understand, but what about my pull request?

@tilkinsc
Copy link
Owner

Sorry, didn't see those commits. In README.portug* you accidently added an extra # making ### Linux and something else which differs from the other readme's. I am not worried about it. I am now prepare to see how bad adding the contribution to the other readme's even though the bot hasn't tracked them yet will go. @all-contributors Please add @acidicMercury8 for translation

@tilkinsc tilkinsc merged commit 9f05e88 into tilkinsc:master Apr 28, 2021
@allcontributors
Copy link
Contributor

@tilkinsc

I've put up a pull request to add @acidicMercury8! 🎉

@tilkinsc
Copy link
Owner

Hooray it didn't do what it was intended to!

@acidicMercury8 acidicMercury8 deleted the readme-improvements branch April 28, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants