-
-
Notifications
You must be signed in to change notification settings - Fork 8
Fixing russian translation and another readme improvements #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tilkinsc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your translation efforts! I like the changes to the text, but there are a few loose ends which you were not aware of. Please review the changes and I'll happily accept this PR!
If you want, more needs translated to russian!
https://github.com/tilkinsc/LuaConsole/blob/master/root/lang/russian.txt
However, LuaConsole doesn't yet fully support multi-language in that it may be broken in some way. I have been busy with life and will get to it eventually!
|
I was going to fix russian localization file in a next pull request. Also I can suggest using the GNU way (throw using .mo/.po files) as a cross-platform one-stop solution for localization/internationalization |
|
This repo has been designed around not having external dependencies. It's not supposed to have flashy OS-dependent features, nor creative libraries which extend functionality at the cost of them being external. Especially not under a GPL license. Please note that CI is currently failing due to the Lua team uploading a fake .tar.gz (its just a .tar) |
|
I understand, but what about my pull request? |
|
Sorry, didn't see those commits. In README.portug* you accidently added an extra |
|
I've put up a pull request to add @acidicMercury8! 🎉 |
|
Hooray it didn't do what it was intended to! |
I noticed the russian translation here and as a native speaker I decided to improve it. The markup problems and markdownlint warnings were fixed along the way