Ensure that all existing objects are advertised when a watch is created #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicksieger @nicks @danegsta please review |
tilt-dev#88 Signed-off-by: Karol Zadora-Przylecki <karolz@microsoft.com>
karolz-ms
force-pushed
the
dev/karolz/watch-init
branch
from
c04839f to
f43b4b1
Compare
karolz-ms
commented
Apr 24, 2025
| require.Equal(t, "2", actual.ResourceVersion) | ||
| } | ||
|
|
||
| func TestFilepathREST_ParallelCreateAndWatch(t *testing.T) { |
There was a problem hiding this comment.
This test always fails (at least on my machine) when run against code currently in main branch
nicksieger
approved these changes
Apr 25, 2025
|
@nicksieger much appreciated, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #88