Bugfix/issue 360 print sha256sum after workflow release

.github/workflows/release_build.yml

@@ -226,6 +226,7 @@ jobs:
 
         PROTON_BINARY=proton-$PROTON_TAG-Darwin-x86_64
         echo "Proton Binary Name: $PROTON_BINARY"
+        sha256sum $GITHUB_WORKSPACE/output/proton
 
         mv $GITHUB_WORKSPACE/output/proton $GITHUB_WORKSPACE/$PROTON_BINARY
     secrets:
@@ -284,6 +285,7 @@ jobs:
 
         PROTON_BINARY=proton-$PROTON_TAG-Darwin-arm64
         echo "Proton Binary Name: $PROTON_BINARY"
+        sha256sum $GITHUB_WORKSPACE/output/proton
 
         mv $GITHUB_WORKSPACE/output/proton $GITHUB_WORKSPACE/$PROTON_BINARY
     secrets:

install.sh

@@ -41,11 +41,16 @@ BINARY_FILE="proton-${LATEST_TAG}-${OS}-${ARCH}"
 TARGET_FILE="proton"
 
 # Check if the proton file exists
+
+# Fix me, what if I wanna use this script 3 times?
+# if `proton` not exist, we use proton
+# else 
+#     1.use `"proton-${LATEST_TAG}-${OS}-${ARCH}"` (by default)
+#     2.overwrite it(only work on manual bash install.sh)
+
 if [ -f "$TARGET_FILE" ]; then
-  echo -n "'proton' file exists. Do you want to overwrite it? (y/n): "
-  read REPLY
-  echo
-  if [ "$(echo $REPLY | cut -c1)" = "y" ] || [ "$(echo $REPLY | cut -c1)" = "Y" ]; then
+  read -p "'proton' file already exists. Do you want to overwrite it? (y/n): " answer
+  if [ "$answer" = "y" -o "$answer" = "Y" ]; then
     TARGET_FILE="proton"
   else
     TARGET_FILE=$BINARY_FILE
@@ -79,6 +84,7 @@ For detailed usage and more information, check out the Timeplus documentation:
 https://docs.timeplus.com/"
 else
   echo "Download failed or the binary for $OS-$ARCH is not available." >&2
+  exit 1
 fi
 
 if [ "${OS}" = "Linux" ]

src/Common/Streaming/Substream/ExecutorImpl.h

@@ -626,14 +626,14 @@ struct ExecutorImpl
 
     /// Return {removed, last_removed_watermark, remaining_size}
     template <DestroyDataFunc<Data>... F>
-    void removeBucketsBefore(Int64 watermark, F &&... destory)
+    void removeBucketsBefore(Int64 watermark, F &&... destroy)
     {
         auto destroy_wrapper = [&](DataPtr & data) {
             if (nullptr == data)
                 return;
 
             Data & data_ref = *reinterpret_cast<Data *>(data);
-            (destory(data_ref), ...);
+            (destroy(data_ref), ...);
 
             data = nullptr;
         };

src/Interpreters/Streaming/Aggregator.cpp

@@ -2357,7 +2357,7 @@ void NO_INLINE Aggregator::mergeDataImpl(
         {
             /// If there are multiple sources, there are more than one AggregatedDataVariant. Aggregator always creates a new AggregatedDataVariant and merge all other
             /// AggregatedDataVariants to the new created one. After finalize(), it does not clean up aggregate state except the new create AggregatedDataVariant.
-            /// If it does not alloc new memory for the 'dst' (i.e. aggregate state of the new AggregatedDataVariant which get destoryed after finalize()) but reuse
+            /// If it does not alloc new memory for the 'dst' (i.e. aggregate state of the new AggregatedDataVariant which get destroyed after finalize()) but reuse
             /// that from the 'src' to store the final aggregated result, it will cause the data from other AggregatedDataVariant will be merged multiple times and
             /// generate incorrect aggregated result.
             dst = arena->alignedAlloc(total_size_of_aggregate_states, align_aggregate_states);