Skip to content

bugfix: comment on ExternalStream was not showed in system.tables #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

bugfix: comment on ExternalStream was not showed in system.tables #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Storages/ExternalStream/StorageExternalStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,13 @@ StorageExternalStream::StorageExternalStream(
ContextPtr context_,
const ColumnsDescription & columns_,
std::unique_ptr<ExternalStreamSettings> external_stream_settings_,
const String & comment,
bool attach)
: IStorage(table_id_), WithContext(context_->getGlobalContext())
{
StorageInMemoryMetadata storage_metadata;
storage_metadata.setColumns(columns_);
storage_metadata.setComment(comment);
setInMemoryMetadata(storage_metadata);

auto stream = createExternalStream(this, std::move(external_stream_settings_), context_, engine_args, attach, std::make_shared<ExternalStreamCounter>(), std::move(context_));
Expand All @@ -167,7 +169,7 @@ void registerStorageExternalStream(StorageFactory & factory)
external_stream_settings->loadFromQuery(*args.storage_def);

return StorageExternalStream::create(
args.engine_args, args.table_id, args.getContext(), args.columns, std::move(external_stream_settings), args.attach);
args.engine_args, args.table_id, args.getContext(), args.columns, std::move(external_stream_settings), args.comment, args.attach);
}
else
throw Exception(ErrorCodes::BAD_ARGUMENTS, "External stream requires correct settings setup");
Expand Down
1 change: 1 addition & 0 deletions src/Storages/ExternalStream/StorageExternalStream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class StorageExternalStream final : public shared_ptr_helper<StorageExternalStre
ContextPtr context_,
const ColumnsDescription & columns_,
std::unique_ptr<ExternalStreamSettings> external_stream_settings_,
const String & comment,
bool attach);

private:
Expand Down