Create documentation for bar chart#1246
Conversation
|
Please allow 10 minutes from last push for the staging site to build. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-Create-documentation-for-bar-chart |
…om/timescale/docs into Create-documentation-for-bar-chart
|
Hey, @DinmaOtutu this is great work! 💖 One question for you: can we standardise on "bar chart" or "bar graph" (and one word or two)? Also, with your permission, can I check out your branch and do some tidying up for style? |
sure! Please, go ahead, I would really appreciate that |
|
Ok! I got everything building finally 😅 The link checker is still failing, but that's because of the anchor tags: because we have to use a static non-reference-style link for those, and that static URL does not properly exist until we push this PR, they will (probably! I've been wrong in the past!) continue to fail until then. Otherwise, the snippet is working correctly, and all other links are looking good 👍 |
|
One small question for @charislam though: Vale is still choking on those semicolons in the snippet import, but I thought we adjusted the Vale rules to account for that? Is there something wrong with the rule, or is not merged yet? |
|
@DinmaOtutu Can you please review the built doc and make sure you're happy with my changes? 💖 |
Yes, I am very okay with the changes, but my question is, it's not being updated on the dev docs page. Is there anything I need to do? |
…om/timescale/docs into Create-documentation-for-bar-chart
We did! I somehow wiped out that commit when I rebased my branch 😬 no idea when that happened. Just fixed it and it should stop flagging those semi-colons now |
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
It could just be caching. Make sure you wait 10-15 mins after the last commit, and try opening it in incognito mode. |
Loquacity
left a comment
There was a problem hiding this comment.
@DinmaOtutu I think you're good to go ahead and merge when you're ready 👍
…om/timescale/docs into Create-documentation-for-bar-chart
thank you so much! Merging it now |
Description
[Short summary of why you created this PR]
Links
Fixes #[insert issue link, if any]
Review checklists
Reviewers: use this section to ensure you have checked everything before approving this PR:
Subject matter expert (SME) review checklist
Documentation team review checklist
and have they been implemented?