Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Create documentation for bar chart#1246

Merged
DinmaOtutu merged 44 commits into
latestfrom
Create-documentation-for-bar-chart
Jul 5, 2022
Merged

Create documentation for bar chart#1246
DinmaOtutu merged 44 commits into
latestfrom
Create-documentation-for-bar-chart

Conversation

@DinmaOtutu
Copy link
Copy Markdown
Contributor

Description

[Short summary of why you created this PR]

Links

Fixes #[insert issue link, if any]

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Are procedure and highlight tags used appropriately?
  • Has the index been updated appropriately?
  • Have any images been uploaded to the correct location, and are resolvable?
  • Are all links provided in reference style, and resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@github-actions
Copy link
Copy Markdown

Please allow 10 minutes from last push for the staging site to build. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-Create-documentation-for-bar-chart

@Loquacity
Copy link
Copy Markdown
Contributor

Loquacity commented Jun 30, 2022

Hey, @DinmaOtutu this is great work! 💖 One question for you: can we standardise on "bar chart" or "bar graph" (and one word or two)? Also, with your permission, can I check out your branch and do some tidying up for style?

@DinmaOtutu
Copy link
Copy Markdown
Contributor Author

Hey, @DinmaOtutu this is great work! 💖 One question for you: can we standardise on "bar chart" or "bar graph" (and one word or two)? Also, with your permission, can I check out your branch and do some tidying up for style?

sure! Please, go ahead, I would really appreciate that

@Loquacity
Copy link
Copy Markdown
Contributor

Ok! I got everything building finally 😅 The link checker is still failing, but that's because of the anchor tags: because we have to use a static non-reference-style link for those, and that static URL does not properly exist until we push this PR, they will (probably! I've been wrong in the past!) continue to fail until then. Otherwise, the snippet is working correctly, and all other links are looking good 👍

@Loquacity
Copy link
Copy Markdown
Contributor

One small question for @charislam though: Vale is still choking on those semicolons in the snippet import, but I thought we adjusted the Vale rules to account for that? Is there something wrong with the rule, or is not merged yet?

@Loquacity Loquacity requested a review from a team July 4, 2022 02:37
@Loquacity
Copy link
Copy Markdown
Contributor

@DinmaOtutu Can you please review the built doc and make sure you're happy with my changes? 💖

@DinmaOtutu
Copy link
Copy Markdown
Contributor Author

DinmaOtutu commented Jul 4, 2022

@DinmaOtutu Can you please review the built doc and make sure you're happy with my changes? 💖

Yes, I am very okay with the changes, but my question is, it's not being updated on the dev docs page. Is there anything I need to do?
Thank you so much for taking out time to update it, I appreciate it. @Loquacity

@charislam
Copy link
Copy Markdown
Contributor

One small question for @charislam though: Vale is still choking on those semicolons in the snippet import, but I thought we adjusted the Vale rules to account for that? Is there something wrong with the rule, or is not merged yet?

We did! I somehow wiped out that commit when I rebased my branch 😬 no idea when that happened. Just fixed it and it should stop flagging those semi-colons now

Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Comment thread timescaledb/tutorials/grafana/visualizations/bar-chart.md Outdated
Loquacity and others added 3 commits July 5, 2022 14:33
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
@Loquacity
Copy link
Copy Markdown
Contributor

but my question is, it's not being updated on the dev docs page. Is there anything I need to do?

It could just be caching. Make sure you wait 10-15 mins after the last commit, and try opening it in incognito mode.

Copy link
Copy Markdown
Contributor

@Loquacity Loquacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DinmaOtutu I think you're good to go ahead and merge when you're ready 👍

@DinmaOtutu
Copy link
Copy Markdown
Contributor Author

@DinmaOtutu I think you're good to go ahead and merge when you're ready 👍

thank you so much! Merging it now

@DinmaOtutu DinmaOtutu merged commit 5c0c09b into latest Jul 5, 2022
@DinmaOtutu DinmaOtutu deleted the Create-documentation-for-bar-chart branch July 5, 2022 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants