Skip to content

CLI Enhancements #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 13, 2020
Merged

CLI Enhancements #44

merged 16 commits into from
Jul 13, 2020

Conversation

@archen2019
Copy link
Contributor

Features:

  • Updated NOTES.txt to display CLI commands when installed with CLI
  • Added timescaledb change-password and helm delete-data command
  • Added --delete-data flag to uninstall command
  • Updated tests, added test for concurrent installs
  • Code duplication cleanup

@archen2019 archen2019 requested review from atanasovskib and cevian July 8, 2020 19:55
cevian
cevian requested changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions below. Also please get rid of the merge commit in the history.

atanasovskib
atanasovskib approved these changes Jul 13, 2020
View reviewed changes
@archen2019 archen2019 merged commit 3899c90 into master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cevian cevian cevian approved these changes

+1 more reviewer

@atanasovskib atanasovskib atanasovskib approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@archen2019 @cevian @atanasovskib